I think the national revolution failed. Even the Northern Expedition failed to achieve the original plan of destroying the three warlords, which made Zhang remain in the northeast. The Northern Expedition can only be said to have dealt a heavy blow to feudal warlords and imperialist forces. Lay a foundation for China to maintain formal reunification. Finally, the national revolution was aborted in the counter-revolutionary coup of Jiang and Wang, and the vigorous national revolution ended in failure.

I want to add a few points to the answers given by several people upstairs: First, Mr. Zhongshan gave way to Yuan Shikai, which was the Revolution of 1911. Don't confuse the Revolution of 1911 with the national revolution. Second, the national revolution began when Mr. Zhongshan convened the first national congress of the Kuomintang, reorganized the Kuomintang and realized the first cooperation between the Kuomintang and the Communist Party. It was not until Wang Jiang launched the coups on April 12 and July 15 that the national revolution ended. Therefore, changing the flag in Northeast China does not belong to the category of national revolution. Third, the merger of Wuhan National Government and Nanjing National Government.

Did China really achieve the unification that Dr. Sun Yat-sen wanted in the 17th year of the Republic of China (1928)? No, after the collapse of the An Guojun government in Zhang and Jing, various factions within the Kuomintang, old and new warlords, evolved into fierce internal struggles, such as the Chiang Kai-shek War and the Central Plains War. China didn't get the unification that Dr. Sun Yat-sen wanted. Even if it is unified, it is only a formal unity, not a real unity.